Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portals - Fix UI default #51186

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Conversation

lawnjelly
Copy link
Member

I had forgotten to add a call to update_portal_tools() at the end of the SpatialEditor constructors. This ensures that the portal UI is off by default in normal use without portals.

Notes

  • Sorry my bad, this was working during production but I must have removed this call at some point. This will have resulted in the 'convert rooms' button showing even if no RoomManager was present.

I had forgotten to add a call to update_portal_tools() at the end of the SpatialEditor constructors. This ensures that the portal UI is off by default in normal use without portals.
@lawnjelly lawnjelly force-pushed the portals_fix_ui_default branch from 9632515 to 9e9abe2 Compare August 2, 2021 15:11
@akien-mga akien-mga merged commit 8f3ec04 into godotengine:3.x Aug 2, 2021
@akien-mga
Copy link
Member

Thanks!

@lawnjelly lawnjelly deleted the portals_fix_ui_default branch August 2, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants