Normalize normals and quaternions. #51194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
force-pushed
the
gltf-vertex-normalize
branch
4 times, most recently
from
ea23a40
to
812a697
Compare
fire
force-pushed
the
gltf-vertex-normalize
branch
from
812a697
to
2ab210c
Compare
Calinou
added
bug
cherrypick:3.x
fire
commented
Aug 3, 2021
| tangent.x = tarr[(i * 4) + 0]; | ||
| tangent.y = tarr[(i * 4) + 1]; | ||
| tangent.z = tarr[(i * 4) + 2]; | ||
| attribs.write[i] = tangent; |
There was a problem hiding this comment.
@BastiaanOlij Can you review this? I think this is incorrect.
There was a problem hiding this comment.
I'm not 100% sure... If I recall the w/a is used on tangents and will be either 1.0 or -1.0 depending on whether the direction of the cross product needs to be flipped to create the bitangent/binormal vector. This saves having to maintain both vectors.
So simply discarding the value in order to encode it seems like a sure way to cause problems...
|
Superseded by: #50019 |
akien-mga
added
archived
and removed
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a series of pr requests improving gltf2 export.
Can be back ported.
Part of #51132