Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action_get_events returning booleans instead of InputKey entries #51375

Merged
merged 1 commit into from
Aug 7, 2021
Merged

Fix action_get_events returning booleans instead of InputKey entries #51375

merged 1 commit into from
Aug 7, 2021

Conversation

Blackiris
Copy link
Contributor

Closes #51374

I have only reverted the change made in InputMap::action_get_events in 4e6efd1.

@Blackiris Blackiris requested a review from a team as a code owner August 7, 2021 19:21
@Calinou Calinou added this to the 4.0 milestone Aug 7, 2021
akien-mga
akien-mga approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, that change was incorrect. The aim was to replace the for () condition by a C++ iterator but this was not done.

@akien-mga akien-mga merged commit 49309ac into godotengine:master Aug 7, 2021
@akien-mga
Copy link
Member

Thanks!

@Blackiris Blackiris deleted the fix-action-get-events branch August 8, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:input
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Method action_get_events return an array of booleans instead of InputEvent
3 participants
@Blackiris @akien-mga @Calinou