Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portals - add support for Sprite3D #51396

Merged
merged 1 commit into from
Aug 8, 2021
Merged

Portals - add support for Sprite3D #51396

merged 1 commit into from
Aug 8, 2021

Conversation

lawnjelly
Copy link
Member

Add support for Sprite3D and animated Sprite3D.

Fixes #51386 (with #51388)

Notes

  • I had simply forgotten these. Poor Sprite3D. 😢
  • The animated version will probably need to be DYNAMIC rather than STATIC if the mesh moves. I'm not familiar with AnimatedSprite3D and whether this occurs, but if we can add it to the docs as similar to the situation with ParticleSystems which also need to be DYNAMIC or have an extra cull margin applied.

@lawnjelly
Portals - add support for Sprite3D
fc3c01d 
Add support for Sprite3D and animated Sprite3D.
@lawnjelly lawnjelly requested a review from a team as a code owner August 8, 2021 14:47
@YeldhamDev YeldhamDev added this to the 3.4 milestone Aug 8, 2021
@akien-mga akien-mga merged commit be22d7b into godotengine:3.x Aug 8, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Aug 8, 2021
Closed
@lawnjelly lawnjelly deleted the portals_sprite3d branch August 8, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:3d
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@lawnjelly @akien-mga @Calinou @YeldhamDev