Quickhull - reduce warning spam and make hideable

[lawnjelly]

Added one more warning to the hideable warnings. These seem to be benign warnings and are hidden during use in rooms and portals. When used from other areas, only one warning is displayed per run, instead of for every occurrence.

Fixes warning reported by @timothyqiu

Notes

• I just missed one of the warnings when doing this originally (this warning occurs more rarely).

[akien-mga]

Could you use WARN_PRINT_ONCE() here instead of using booleans to defer it?

[lawnjelly]

I can easily change these to WARN_PRINT_ONCEs within the if statements.

This is just me, my reflex action is to write less branches 😁 . But in this case readability is probably the most important factor.

[lawnjelly]

Ah no on second thoughts, it would involve 3 if statements because of the _flag_warnings parameter. So it may be better how it currently is, otherwise the logic in the hot loop could become harder to follow in terms of readability...

I.e. it would end up being:

if (unlikely(!F2))
{
    if (_flag_warnings)
    {
        WARN_PRINT_ONCE etc
    }
    continue;
}

I don't know which is preferred. I'd still slightly come out with the WARN_PRINTs separate as slightly better, but either is fine, I can change it, just let me know.

[akien-mga]

All that logic is quite awkward IMO.

Errors and warnings should point at things that are either:

• Engine bugs that we need to fix.
• User mistakes where they pass invalid input.

If it's neither of those and those are benign cases which are not meant to call the user's attention, they should just be replaced by silent continue. If they are signs that the user or the engine is using bogus data, that's something we should fix.

[lawnjelly]

Not sure what the CI failure is about. Has something been merged that hasn't updated the docs?

[akien-mga]

Not sure what the CI failure is about. Has something been merged that hasn't updated the docs?

Something was merged that had updated the docs properly, but we since changed the docs formatting :D

[akien-mga]

Something was merged that had updated the docs properly, but we since changed the docs formatting :D

Fixed.

[akien-mga]

Thanks!