Triple click in text editor now uses last mouse position for validity

[codecat]

Previously, you would be able to double click a word, followed by single-clicking another word on the same line, which would select the entire line. Now, it will only select the whole line if the mouse position has remained the same after the double click. This mimics the behavior in most third party text editors.

This fixes #51312.

[akien-mga]

Shouldn't there be a tolerance of a few pixels for unintentional mouse movement?

I checked on Firefox/GTK3 on Linux and triple click select seems to work if I'm moving very slightly while still triple clicking fast. Not sure what the tolerance used is but it might 5 px or something.

[codecat]

You're correct, I've never noticed this! Although it doesn't seem to be the case on VSCode, it seems like everywhere else there is indeed a tolerance.

[akien-mga]

Looks good! Could you squash the commits into one? See PR workflow for instructions.

[Ansraer]

Damn it, you beat me to it by a day...
I am just gonna blame my slow internet and the good weather.

[codecat]

Is the Linux CI failure something I should concern myself with?

[Calinou]

Is the Linux CI failure something I should concern myself with?

The CI log says:

Run echo "Running --doctool to see if this changes the public API without updating the documentation."
Running --doctool to see if this changes the public API without updating the documentation.
If a diff is shown, it means that your code/doc changes are incomplete and you should update the class reference with --doctool.


diff --git a/doc/classes/@GlobalScope.xml b/doc/classes/@GlobalScope.xml
index 3dfb0f4..7c954df 100644
--- a/doc/classes/@GlobalScope.xml
+++ b/doc/classes/@GlobalScope.xml
@@ -213,10 +213,8 @@
 			</description>
 		</method>
 		<method name="error_string">
-			<return type="String">
-			</return>
-			<argument index="0" name="error" type="int">
-			</argument>
+			<return type="String" />
+			<argument index="0" name="error" type="int" />
 			<description>
 				Returns a human-readable name for the given error code.
 			</description>
Error: Process completed with exit code 1.

You need to update the class reference to resolve this. To do so, compile an editor binary then run it with --doctool from the root Godot folder.

Edit: This is an issue with a PR that was merged today, and was fixed by #51523 since. I recommend rebasing on the latest master branch to resolve it.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[akien-mga]

Cherry-picked for 3.4.