Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Improve NavigationMesh typing, parameter validation and documentation #51499

Merged
merged 1 commit into from
Aug 11, 2021
Merged

[3.x] Improve NavigationMesh typing, parameter validation and documentation #51499

merged 1 commit into from
Aug 11, 2021

Conversation

timothyqiu
Copy link
Member

  • Document properties and methods of NavigationMesh and NavigationMeshInstance.
    • Descriptions of baking parameters are mainly taken from their corresponding recast field comments.
  • Expose SamplePartitionType, ParsedGeometryType, SourceGeometryMode enums to scripts.
    • Also changed the return type of getters and the argument type of setters from int to the corresponding enum.
  • Added parameter validation for various setters.

@timothyqiu timothyqiu added this to the 3.4 milestone Aug 11, 2021
@timothyqiu timothyqiu requested review from a team as code owners August 11, 2021 08:34
@timothyqiu timothyqiu mentioned this pull request Aug 11, 2021
Merged
@akien-mga akien-mga merged commit 91cb296 into godotengine:3.x Aug 11, 2021
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the navmesh-doc-3x branch August 11, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:3d
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyqiu @akien-mga