Style: Cleanup code using text_editor/completion/use_single_quotes
#51642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Aug 13, 2021
| text_to_drop += "\"" + path.c_escape() + "\""; | ||
| text_to_drop += path.c_escape().quote(quote_style); |
There was a problem hiding this comment.
This wasn't respecting the setting.
akien-mga
commented
Aug 13, 2021
Comment on lines
+2672
to
+2673
| String path = "/root/" + E->key(); | ||
| ScriptCodeCompletionOption option(path.quote(quote_style), ScriptCodeCompletionOption::KIND_NODE_PATH); |
There was a problem hiding this comment.
Refactored a bit to be able to use String::quote() like in other calls.
akien-mga
force-pushed
the
cleanup-use_single_quotes
branch
from
384cbc1 to
81512a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #51628.
Fixes one cases where the setting was not respected, otherwise it's just style cleanup.