Auto-reload scripts with external editor

[yjh0502]

The PR allows auto-reload with external editors.

• It calls _live_auto_reload_running_scripts when appropriates.
• It uses NOTIFICATION_APPLICATION_FOCUS_IN events to trigger reload as NOTIFICATION_WM_WINDOW_FOCUS_IN is never called on master branch. I'm not sure why, probably a bug?

Here's another patch for 3.x branch. It also fixes error messages when script changed on external editor. (Another resource is loaded from path thing). I could create another PR if you prefer: https://gist.github.com/yjh0502/e2cb62f9216c953c8e54541199d7be09

related: #10946

Bugsquad edit: Fix #10946

[Paulb23]

NOTIFICATION_WM_WINDOW_FOCUS_IN not triggering is a bug see also #47176. Not sure it's worth adding workarounds for it.

[Paulb23]

Should only call this if a script has been reloaded and pending_auto_reload == false

[yjh0502]

NOTIFICATION_WM_WINDOW_FOCUS_IN not triggering is a bug see also #47176. Not sure it's worth adding workarounds for it.

Let's fix the bug first (ref: #51781). I'll update this PR after merging #51781

[yjh0502]

@Paulb23 I tried to address the issue you mentioned. Unfortunately I'm not good at naming, so please feel free to suggest another name :)

[Paulb23]

Looks good. No worries :) as far as naming goes perhaps _trigger_live_script_reload?

[yjh0502]

Looks good. No worries :) as far as naming goes perhaps _trigger_live_script_reload?

Thanks for your suggestion, I changed the name.

[akien-mga]

Thanks!

[rversteegen]

Very pleased to see this fixed!

Here's another patch for 3.x branch. It also fixes error messages when script changed on external editor. (Another resource is loaded from path thing). I could create another PR if you prefer: https://gist.github.com/yjh0502/e2cb62f9216c953c8e54541199d7be09

Do I understand that this separate patch is needed to fix the error messages? Will this also get applied? Those errors are annoying and distracting.

[yjh0502]

@rversteegen The error message problem was already fixed on master branch, and I fixed the error message issue while back-porting this patch to 3.x branch, which is already merged. See also: #51828

[cptchuckles]

This doesn't quite fix the issue I was having with the editor in #49298, particularly where export vars don't get updated after I save a script and return focus to the Godot editor, unless I close and re-open the scene. My PR #49473 addresses that but it needs a review