Entirely removes BIND_VMETHOD in favor of GDVIRTUAL #51983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduz
force-pushed
the
remove-bind-vmethod
branch
from
98eb3b0
to
c36bcee
Compare
reduz
force-pushed
the
remove-bind-vmethod
branch
from
c36bcee
to
6b23c41
Compare
aaronfranke
reviewed
Aug 22, 2021
KoBeWi
reviewed
Aug 22, 2021
KoBeWi
reviewed
Aug 22, 2021
KoBeWi
reviewed
Aug 23, 2021
KoBeWi
reviewed
Aug 23, 2021
* `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
reduz
force-pushed
the
remove-bind-vmethod
branch
from
6b23c41
to
5cecdfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_gui_input,_input,_unhandled_inputand_unhandled_key_inputare now regular C++ virutal functions.Creating
_gui_inputmethod and using the binder to register events will no longer work, simply override the virtual function now.