-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak Glow defaults for a more visually pleasing appearance #52227
base: master
Are you sure you want to change the base?
Conversation
I would tweek the levels too. I find using level 5 adds too much to the glow. What I find more please IMO is: |
30b5116
to
a9f381b
Compare
I updated the pull request to adjust the default glow levels per #52227 (comment). See OP for an updated Imgsli comparison. |
a9f381b
to
3fa96d8
Compare
I think this needs to be better discussed, maybe using mix glow mode and normalized, the soft one rarely has any effct. |
3fa96d8
to
78c9963
Compare
I've pushed those new Glow defaults to https://github.com/Calinou/godot-reflection if anyone wants to see them in a "real world" scene. (I reduced the intensity to 0.2 as this is a scene with a bright sky.) |
Any progress on this? I don't want to needlessly bump this but it's been like half a year. |
In my experiments I've found that setting all the levels to 1 and normalizing, with intensity at 0.8, and strength at 1, with soft light (so current default aside from levels and normalization) produces the best results, with a subtle, stable effect on bright surfaces, that smoothly increases as the brightness increases |
- Use the Screen blend mode instead of Soft Light. - Use a lower intensity to compensate for the stronger appearance of the Screen blend mode instead of Soft Light. - Tweak glow levels to only use the first 4 levels in a more "progressive" manner.
78c9963
to
f841217
Compare
Testing project: test_glow.zip
Preview
See this Imgsli comparison: https://imgsli.com/NjkwMjc
There are additional images you can select to compare with disabled glow and Screen mode with intensity 0.8.