Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Glow defaults for a more visually pleasing appearance #52227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 29, 2021

Testing project: test_glow.zip

Preview

See this Imgsli comparison: https://imgsli.com/NjkwMjc
There are additional images you can select to compare with disabled glow and Screen mode with intensity 0.8.

@jcostello
Copy link
Contributor

I would tweek the levels too. I find using level 5 adds too much to the glow. What I find more please IMO is:
Level1: 1
Level2: .8
Level3: .4
Level4: .1

@Calinou Calinou force-pushed the glow-tweak-defaults branch 2 times, most recently from 30b5116 to a9f381b Compare August 31, 2021 15:32
@Calinou
Copy link
Member Author

Calinou commented Aug 31, 2021

I updated the pull request to adjust the default glow levels per #52227 (comment). See OP for an updated Imgsli comparison.

@reduz
Copy link
Member

reduz commented Nov 16, 2021

I think this needs to be better discussed, maybe using mix glow mode and normalized, the soft one rarely has any effct.

@Calinou
Copy link
Member Author

Calinou commented May 25, 2022

Rebased and tested again, it works as expected.

Comparison in a daytime scene with bright materials (most scenes won't be this bright):

No glow Old glow New glow (this PR)
2022-05-25_09 58 31_no_glow 2022-05-25_09 57 44_glow_old 2022-05-25_09 57 27_glow_new

Notice how the new glow is more localized. It better preserves scene contrast and avoids looking like it's brightening the entire scene.

@Calinou
Copy link
Member Author

Calinou commented Jun 17, 2022

I've pushed those new Glow defaults to https://github.com/Calinou/godot-reflection if anyone wants to see them in a "real world" scene. (I reduced the intensity to 0.2 as this is a scene with a bright sky.)

@atirut-w
Copy link
Contributor

atirut-w commented Dec 28, 2022

Any progress on this? I don't want to needlessly bump this but it's been like half a year.

@clayjohn clayjohn modified the milestones: 4.0, 4.x Jan 25, 2023
@aaronfranke aaronfranke modified the milestones: 4.x, 5.0 Feb 24, 2023
@mrjustaguy
Copy link
Contributor

In my experiments I've found that setting all the levels to 1 and normalizing, with intensity at 0.8, and strength at 1, with soft light (so current default aside from levels and normalization) produces the best results, with a subtle, stable effect on bright surfaces, that smoothly increases as the brightness increases

@akien-mga akien-mga removed this from the 5.0 milestone Mar 5, 2023
@akien-mga akien-mga added this to the 4.x milestone Mar 5, 2023
- Use the Screen blend mode instead of Soft Light.
- Use a lower intensity to compensate for the stronger appearance
  of the Screen blend mode instead of Soft Light.
- Tweak glow levels to only use the first 4 levels in a more
  "progressive" manner.
@Calinou Calinou force-pushed the glow-tweak-defaults branch from 78c9963 to f841217 Compare March 19, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants