Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed seeking behavior of property track with discrete interpolation #52555

Merged

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Sep 10, 2021

Fixed #52518 in conjunction with #52543.

AnimationNodeTransition seeks the animation of transition destination, but the seeking of property track with discrete interpolation was broken. With track of discrete interpolation, it may be wrong to do nothing in the frame of seeking.

@TokageItLab TokageItLab requested a review from a team as a code owner September 10, 2021 21:03
@TokageItLab TokageItLab changed the title Fixed seeking behavior of value track with discrete animation Fixed seeking behavior of Value Track with discrete interpolation Sep 10, 2021
@TokageItLab TokageItLab force-pushed the fixed-discrete-animation-seek branch from b147d3b to ff3f911 Compare September 10, 2021 21:08
@TokageItLab TokageItLab changed the title Fixed seeking behavior of Value Track with discrete interpolation Fixed seeking behavior of property track with discrete interpolation Sep 10, 2021
@TokageItLab TokageItLab force-pushed the fixed-discrete-animation-seek branch from ff3f911 to 6613d9c Compare September 10, 2021 21:10
@Calinou Calinou added this to the 4.0 milestone Sep 10, 2021
@Calinou Calinou added cherrypick:3.3 cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Sep 10, 2021
@akien-mga akien-mga merged commit 132ad85 into godotengine:master Sep 20, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 20, 2021
@sugarsthenewwhite
Copy link

sugarsthenewwhite commented Jul 20, 2022

is this issue fixed? because i can still experience a one frame delay in animation tree node state machine in 3.4.4 when he said he cherry picked it for 3.3, sorry if i'm not supposed to comment here, i'm new to github.

@TokageItLab
Copy link
Member Author

TokageItLab commented Jul 20, 2022

State machine has different playback method, so probably that is separated issue.

@sugarsthenewwhite
Copy link

State machine has different playback method, so probably that is separated issue.

oh then do i open a new issue and provide the details of reproduce? i haven't seen one that is specific to state machine so far.

@TokageItLab
Copy link
Member Author

I think there was an issue somewhere about the first frame after the StateMachine transition is broken, but I can't remember. BTW, the animation team has already confirmed that the StateMachine transitions are broken.

@sugarsthenewwhite
Copy link

its good that at least they are aware, i hope it gets a polish soon because animation tree has some great potential that you cant have full use of due to small inconveniences like this.

@TokageItLab TokageItLab deleted the fixed-discrete-animation-seek branch September 16, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnimationTree undesired transition delay
4 participants