[HTML5] Refactor audio drivers. Implement AudioWorklet w/o threads. #52649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performances are not great in general, bad on Firefox, on Chrome, well, it could be an improvement. Leave it as a fallback for now, but can be forced via project settings if desired (or custom JavaScript logic via the "args" option). I'm actually surprised this works, it involves so many allocations, but there's no way around it when SharedArrayBuffer is not available :(.
Faless
force-pushed
the
js/4.x_audioworklet_nothreads_pr
branch
from
f1dda50
to
246334b
Compare
akien-mga
approved these changes
Sep 21, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Fix build error due to missing string cast(done via 490511f - [HTML5] Fix input not working when buffered. #52604).Use browser mix rate by default on the Web(done via [HTML5] Use browser mix rate by default on the Web. #52695).Fix bug in AudioWorklet when reading output buffer (exception due to out-of-bound set).(done via [HTML5] Fix bug in AudioWorklet when reading output buffer. #52696)Default HTML template prefers AudioWorklet on Chrome (this is questionable, and should probably be tested across devices).(will skip this for now).Performances are not great in general, bad on Firefox, on Chrome, well, it's an improvement compared to the way they broke ScriptProcessorNode.
Works by sending chunks via postMessage, which is really slow.
I'm actually surprised this works, it involves so many allocations, but there's no way around it when SharedArrayBuffer is not available :(.
Related to #47453