Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection getter methods to LineEdit #53000

Merged

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Sep 24, 2021

Adds has_selection, get_selection_from and get_selection_to methods to LineEdit class. They are named like in TextEdit where similar methods are implemented.

Closes godotengine/godot-proposals#61

@Chaosus Chaosus requested review from a team as code owners September 24, 2021 08:03
@Chaosus Chaosus added this to the 4.0 milestone Sep 24, 2021
@akien-mga
Copy link
Member

Adds has_selection, get_selection_from_line and get_selection_to_line methods to LineEdit class. They are named like in TextEdit where similar methods are implemented.

LineEdit is a single line, no? So I don't understand what from_line and to_line would be aside from 0?

@Chaosus Chaosus force-pushed the lineedit_expose_selection_methods branch 2 times, most recently from eec3404 to be4d26f Compare September 24, 2021 08:15
@Chaosus Chaosus force-pushed the lineedit_expose_selection_methods branch from be4d26f to 4e0552a Compare September 24, 2021 08:31
@Chaosus
Copy link
Member Author

Chaosus commented Sep 24, 2021

Renamed to get_selection_from_column / get_selection_to_column.

@akien-mga akien-mga merged commit 6c0f44c into godotengine:master Sep 29, 2021
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the lineedit_expose_selection_methods branch September 29, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose LineEdit selection begin and end
3 participants