[3.x] Fix crash when creating thread #53060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
requested changes
Oct 1, 2021
There was a problem hiding this comment.
instance_validate() will falsely approve a new object that happened to be created in the same memory address of an already deleted one. In order to have a robust check in 3.x, _Thread should store the target instance as its ObjectID and the Object * would be obtained via ObjectDB::get_instance(), which will give null if the object's already gone.
timothyqiu
force-pushed
the
thread-obj-3.x
branch
from
22ec092 to
7be67ee
Compare
RandomShaper
approved these changes
Oct 3, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.xversion of #53059Unlike the
masterversion, this usesObjectDB::instance_validate()to validateObject *.