SCons: Add DEV_ENABLED defines for target=debug builds
#53383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow adding developer checks which will be fully compiled out in user builds, unlike `DEBUG_ENABLED` which is included in debug tempates and the editor builds. This define is not used yet, but we'll soon add code that uses it, and change some existing `DEBUG_ENABLED` checks to be performed only in dev builds. Related to godotengine/godot-proposals#3371.
lawnjelly
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow adding developer checks which will be fully compiled out in
user builds, unlike
DEBUG_ENABLEDwhich is included in debug tempates andthe editor builds.
This define is not used yet, but we'll soon add code that uses it, and change
some existing
DEBUG_ENABLEDchecks to be performed only in dev builds.Related to godotengine/godot-proposals#3371.
Notes
I'm making this PR for
3.xonly, as formasterwe'll want to have a full implementation of godotengine/godot-proposals#3371, changing the way we currently conflate C++ development tooling and user game debugging tooling under the same flags.I'm not implementing that proposal just yet as it will create additional work for the contributors working on a potential Meson port, which needs to be evaluated first before refactoring the SCons buildsystem.
For
3.xthis will allow @lawnjelly to add dev checks in various areas he's working on, and we might retrofit some of the existing checks in the new system.