-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GLES2 ambient light flickering with multiple refprobes #53740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, subject to CI passing!
edit: for future reference, this PR fixes the ambient light flickering experienced by users when there are 2 or more probes in the scene and it documents the limitation that each object on receives light from the nearest 2 reflection probes
6cffd12
to
3e5ee9c
Compare
Can you please squash your two commits into one before we merge? How to do so is described here: https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase |
This patch fixes rendering of multiple reflection probes for a single mesh in the GLES2 renderer. If there were two reflection probes, one of them would always have the `interior` option flipped, resulting in broken blending between probes and flickering of ambient reflection. Also make note of GLES2 reflection probe limit
3e5ee9c
to
e230bc6
Compare
Windows build failure is unrelated to this PR (GitHub Actions availability issue). |
Thanks! |
Fixes #36399