[3.x] Restrict the project data directory configuration

[m4gr3d]

Limits the configuration range for the project data directory.

[Listwon]

You were right about == problem here and begins_with with concatenated "/" should cover what we wanted to achieve, no need to do both (or I'm missing something here again, I've just tried debugging it and p_path always includes slash at the end).

[m4gr3d]

I wanted to cover the case where p_path didn't include slash at the end.
If it's guaranteed to always include a / at the end, I can remove the == check.

[m4gr3d]

It looks like it's possible for the p_path to not have a trailing slash when this function is invoked.
See

godot/editor/editor_export.cpp

Line 446 in 2b5d89e

if (EditorFileSystem::_should_skip_directory(cur_dir + dir)) {

for the case where the cur_dir is the root directory (e.g: res://).

[Listwon]

Please also review EditorFileDialog::_item_list_item_rmb_selected change you've made previously as
if (item_meta["path"] == "res://.import") { (which I assume worked fine before)
was changed to
if (item_meta["path"] == ProjectSettings::get_singleton()->get_project_data_path()) { (looks reasonably)
and then to
if (String(item_meta["path"]).begins_with(ProjectSettings::get_singleton()->get_project_data_path())) { (not sure why)

The MRP covering edge cases would be appreciated.

[m4gr3d]

Please also review EditorFileDialog::_item_list_item_rmb_selected change you've made previously as if (item_meta["path"] == "res://.import") { (which I assume worked fine before) was changed to if (item_meta["path"] == ProjectSettings::get_singleton()->get_project_data_path()) { (looks reasonably) and then to if (String(item_meta["path"]).begins_with(ProjectSettings::get_singleton()->get_project_data_path())) { (not sure why)

The MRP covering edge cases would be appreciated.

This change was made in master prior to my changes. I merely update the logic to follow suit.
See

godot/editor/editor_file_dialog.cpp

Line 591 in d956904

if (String(item_meta["path"]).begins_with(ProjectSettings::get_singleton()->get_project_data_path())) {

(the previous logic was String(item_meta["path"]).begins_with("res://.godot").

[akien-mga]

Thanks!