Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Don't box params on Native->C# calls with Variant params #53942

Merged
merged 2 commits into from
Nov 8, 2021
Merged

[3.x] Don't box params on Native->C# calls with Variant params #53942

merged 2 commits into from
Nov 8, 2021

Commits on Nov 3, 2021

  1. Don't box params on Native->C# calls with Variant params 

    Godot uses Variant parameters for calls to script methods.
Up until now we were boxing such parameters when marshalling
them for invokation, even if they were value types.

Now Godot allocates the marshalled parameters on the stack,
reducing the GC allocations resulted from boxing.
    @neikeq @raulsntos
    neikeq authored and raulsntos committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    b775573 View commit details
    Browse the repository at this point in the history

  2. C#: Fix property set call boxing value when unboxed was expected

    @neikeq @raulsntos
    neikeq authored and raulsntos committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    e282ee0 View commit details
    Browse the repository at this point in the history