GLTF Texture Filter Importing #54044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is based on the issue: #45206 |
|
Currently, these three cube models are not importing correctly with the current code. Investigation is ongoing. |
|
Policy is that we backport from master to 3.x. So I'll see if I can help you. |
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3 to
c58391c
Compare
|
@TheTophatDemon What's the status of this PR? |
I believe @fire made a separate pull request to continue working on this, since I ran out of time in my schedule. |
|
Superseded by #66856. Thanks for the contribution nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GLTF/GLB importer does not seem to be taking into account filter, wrapping, and mipmap settings built into the file.
This feature implements a fix on the 3.x branch by creating and parsing the texture sampler objects from the GLTF file and applying its properties as flags to the created textures.