-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix primary clipboard warning #54045
Fix primary clipboard warning #54045
Conversation
Can the getter also trigger errors on platforms where it's not supported, while using LineEdit/TextEdit normally? |
01837fc
to
09058fd
Compare
Yes, you are right, now I have also removed the error message from the getter. |
Looking at the implementation again, I think I was a bit too fast to merge it. The code in LineEdit and TextEdit assumes that the Linux-specific primary clipboard actions are valid, and handles them regardless of that fact. So that means that hitting middle mouse button on Windows will actually deselect, change caret position, and grab focus - when nothing else happens because it's not a valid action in this environment. Maybe there should be a |
Initially the code in line_edit, rich_text_label and text_edit was inside then @Paulb23 suggested to remove them. |
Ah, good point.
|
09058fd
to
580a4ae
Compare
I've added FEATURE_CLIPBOARD_PRIMARY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my last review comment, this looks good to merge.
580a4ae
to
8c48b4a
Compare
Thanks! |
Remove warning, should fix #54037