Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to make selection unique #54166

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Add option to make selection unique #54166

merged 1 commit into from
Oct 27, 2021

Conversation

ConteZero
Copy link
Contributor

This should solve #27511
It is based on #27517 but uses a simpler implementation and deselection is done on focus lost.

@ConteZero ConteZero requested review from a team as code owners October 23, 2021 20:23
@YeldhamDev YeldhamDev added this to the 4.0 milestone Oct 23, 2021
@YeldhamDev YeldhamDev linked an issue Oct 23, 2021 that may be closed by this pull request
Select All can leave old highlights behind. #27511
Closed
Paulb23
Paulb23 requested changes Oct 25, 2021
View reviewed changes
Copy link
Member

@Paulb23 Paulb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense as a solution.

I would however rename it to be a bit more explicit something like: deselect_on_focus_loss or keep_selection_on_focus_loss

scene/gui/text_edit.cpp Show resolved Hide resolved
scene/gui/text_edit.cpp Outdated Show resolved Hide resolved
scene/gui/text_edit.cpp Outdated Show resolved Hide resolved
scene/gui/line_edit.cpp Outdated Show resolved Hide resolved
@ConteZero ConteZero force-pushed the unique_selection branch 2 times, most recently from d3ece36 to 14a0960 Compare October 25, 2021 20:52
Paulb23
Paulb23 reviewed Oct 26, 2021
View reviewed changes
scene/gui/text_edit.h Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit 21529c9 into godotengine:master Oct 27, 2021
@akien-mga
Copy link
Member

Thanks!

@ConteZero ConteZero mentioned this pull request Oct 28, 2021
Merged
@Calinou Calinou mentioned this pull request Nov 25, 2021
Closed
@bruvzg bruvzg mentioned this pull request Mar 14, 2022
Merged
@ConteZero ConteZero deleted the unique_selection branch March 15, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paulb23 Paulb23 Paulb23 approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Select All can leave old highlights behind.
4 participants
@ConteZero @akien-mga @Paulb23 @YeldhamDev