GLES2: Disable half float on iOS via platform override #54229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be changed back by setting `rendering/gles2/compatibility/disable_half_float.iOS` to false. Fixes godotengine#31907.
akien-mga
force-pushed
the
3.x-ios-disable-high-float
branch
from
efac2ed
to
bc0d18d
Compare
clayjohn
approved these changes
Oct 25, 2021
|
So we've had this option since #38453 last year, and the plan was to make it the default/only behavior once sufficiently tested... but we forgot. It worked well for the iOS users who did test it, so I think we can take the risk and merge it now for 3.4 RC 2. Worst case, if it causes issues which aren't found before 3.4-stable, affected users will just have this boolean setting to flip, until we fix issues in 3.4.1. |
This was referenced Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be changed back by setting
rendering/gles2/compatibility/disable_half_float.iOSto false.Fixes #31907.