Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PowerPC family #54490

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Add support for PowerPC family #54490

merged 1 commit into from
Nov 1, 2021

Conversation

q66
Copy link
Contributor

@q66 q66 commented Nov 1, 2021

This adds support for the PowerPC architectures. Tested on ppc64le POWER9, with Radeon RX 5500 XT. Big endian ppc64 is known to at least build, though likely has bugs.

@Calinou
Copy link
Member

Calinou commented Nov 1, 2021

For future reference, RISC-V support was implemented in #53508. That PR may be usable as reference if you need to modify other things.

(PS: Long time no see 🙂)

@q66
Copy link
Contributor Author

q66 commented Nov 1, 2021

note: this requires build with system libpng (as the bundled libpng has a common problem that bundled libpngs have: the ppc64 altivec/vsx intrinsics code was not imported, but was left enabled)

that can be left for a separate fix though, i think

(i am submitting this after i found a recent update to 3.3.4 in our distribution broke ppc builds because of embree; i've made a downstream patch and then adapted it to master, and built it locally)

@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 1, 2021
@akien-mga akien-mga merged commit 7b83039 into godotengine:master Nov 1, 2021
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants