[Export] Read and ZIP project files in 16K chunks instead of reading the whole file at once. #54673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the whole file at once.
bruvzg
added
bug
platform:macos
topic:editor
cherrypick:3.x
|
Does this slow down exporting times noticeably? If so, a larger buffer (like 64 KB or 256 KB) could be used. |
I have not noticed any substantial difference between original code and this one with 16 KB, 256 KB and 1 MB buffers. But I guess it might depend on the hardware. Godot already is using the same code with 16 KB buffer to read and write files to the PCK file. |
akien-mga
approved these changes
Nov 6, 2021
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read and ZIP files in chunks instead of reading the whole file into the single
Vectorto avoidVectorlimitations (and excessive memory usage).Fixes #54670