Only rotate Android sensor values for sensors that need them rotated #55183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added the missing break statements and added the validation of the float values[] parameter. |
m4gr3d
approved these changes
Dec 15, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on Android,
onSensorChanged()callsDisplay.getRotation()whether or not it's needed. As identified by @ICatRegister, this may cause input dispatching to time out and the game to crash.This PR ensures that
Display.getRotation()is only called for sensors that need it. It also refactors the way the values are adjusted depending on the rotation to make it clearer what is being done.Fixes #41421
Closes #53909