-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak "No Undo" texts for consistency #55233
base: master
Are you sure you want to change the base?
Conversation
All "No Undo" texts are now written in uppercase to be more noticeable, since there's a risk of data loss.
5ec0cc9
to
8725dcf
Compare
I'm not sure about this, it seems tricky for localization. I wouldn't know how to translate this to French without having something super cumbersome and aggressive looking (like "PAS D'ANNULATION"). It's also not a proper English sentence so might be difficult to translate even as is. Maybe we can rethink this UX? For example this could be a second paragraph in the ConfirmationDialog:
|
For dialogs, this is a good idea. However, I'm not sure about buttons that include a "No Undo" text such as the "Replace All" button in the Replace in Files dialog. |
There is some space there, we can add a (bold?) label next to the button with more explicit text. |
@@ -6265,7 +6265,7 @@ AnimationTrackEditor::AnimationTrackEditor() { | |||
cleanup_all->set_text(TTR("Clean-up all animations")); | |||
cleanup_vb->add_child(cleanup_all); | |||
|
|||
cleanup_dialog->set_title(TTR("Clean-Up Animation(s) (NO UNDO!)")); | |||
cleanup_dialog->set_title(TTR("Clean-Up Animation(s) (NO UNDO)")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be in the text instead of title, like in other cases?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Would be good to update this based on the discussion so far, I think the proposed changes would make the UX much nicer already. |
All "No Undo" texts are now written in uppercase to be more noticeable, since there's a risk of data loss.