Emit node configuration warnings for GeometryInstance3D distance fade #55370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visibility range begin/end margin properties must be set above 0.0 for the fade transition to be visible.
Yeah, intermediate LOD levels grant using different fade modes on the begin and far range limits, so the PR looks good as it is now. |
JFonS
approved these changes
Jan 4, 2022
Calinou
deleted the
geometryinstance3d-lod-fade-node-configuration-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visibility range begin/end margin properties must be set above 0.0 for the fade transition to be visible.
This closes #55366.
Question: Are there use cases where you want only one of the transitions to be smooth? Is this needed for intermediate LOD levels (when you have 3 or more LOD levels), for instance? Right now, the node configuration warning will be emitted individually for the "begin" and "end" fade transitions. If this is a problem, we should merge both together and only emit a single warning if neither of the transitions have a non-zero margin.