Camera2D: Fix condition on 'jump to limits' logic #55417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for: godotengine#54856
akien-mga
changed the title
akien-mga
added
cherrypick:3.4
cherrypick:3.x
akien-mga
approved these changes
Nov 29, 2021
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #49409 (which was created for #32596) introduced a regression where if a user has
smoothing_enabled = falseandlimit_smoothed = trueon aCamera2D, and the camera is pointing outside any defined limits, the camera would simply be stuck untilreset_smoothing()was called.This change updates the logic that decides whether to smooth into bounds to be effective only if
smoothing_enabled && limit_smoothing_enabled.(For anyone needing a workaround prior to this being merged, either set
limit_smoothedtofalseor invokereset_smoothing()manually.)Fixes #54856.