Expose AudioStreamMP3 loop properties to the editor inspector

[DeleteSystem32]

Exposes loop and loop_offset properties of AudioStreamMP3 resources to the editor inspector to mirror behaviour of other AudioStream resources. Addresses #53855.

I'm not 100% sure this should be both an editor property and an import setting, what's the general consensus on this?

Bugsquad edit: Fix #53855

[ellenhp]

What's the use-case for this? The only thing I can think of is that it could be useful for making many copies of the same audio resource without making many copies of the same file (e.g. by opening the audio stream in the inspector, making edits, then doing a save-as operation to persist those changes in a tres). Does that sound about right or is there more we can do with this?

[Nukiloco]

What's the use-case for this? The only thing I can think of is that it could be useful for making many copies of the same audio resource without making many copies of the same file (e.g. by opening the audio stream in the inspector, making edits, then doing a save-as operation to persist those changes in a tres). Does that sound about right or is there more we can do with this?

In the editor properties, you can set the loop and loop_offset for ogg type of audio however currently you can't set the loop and loop_offset for mp3 type of audio.

[DeleteSystem32]

What's the use-case for this? The only thing I can think of is that it could be useful for making many copies of the same audio resource without making many copies of the same file (e.g. by opening the audio stream in the inspector, making edits, then doing a save-as operation to persist those changes in a tres). Does that sound about right or is there more we can do with this?

In the editor properties, you can set the loop and loop_offset for ogg type of audio however currently you can't set the loop and loop_offset for mp3 type of audio.

This is the main reason. AudioStreamMP3 is the only AudioStream type that doesn't have these properties exposed, so this is mainly for consistency and to avoid confusion. To add, not having to re-import just to change the loop and loop_offset properties might save some people some time.

[ellenhp]

I don't agree that this will avoid confusion, but I'm approving it anyway because I don't like that MP3s are different from the rest of the streams right now. If anything I think it's pretty confusing that these properties will now show up in the inspector and the import options screen, but that's just a quirk of the way Godot works. Thanks for finding this and bringing the mp3 stream to parity!

[akien-mga]

Yes it's a source of confusion for users that needs to be addressed more generally for all audio formats. It's good to make MP3 match the current status quo indeed.

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 3.5.

[akien-mga]

Cherry-picked for 3.4.1.