Fix files_dropped in HTML5 export mono builds. #55594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
platform:web
topic:porting
cherrypick:3.4
cherrypick:3.x
(Ignore trailing slash when creating the temporary directory)
Fro-Z
force-pushed
the
fix-html-file-drop
branch
from
4bbe11a
to
40f26cb
Compare
|
(Updated commit author because I was using old git config. Otherwise no change to the code) |
|
@Fro-Z are you using a custom build? I can't reproduce the linked issue with official 3.4 builds, but it's something that might have changed in more recent emscripten versions (I know they are doing and heavy refactoring of the FS library). |
|
@Faless No, I am using the official 3.4 mono release. Godot Engine v3.4.stable.mono.official.206ba70f4 to be precise |
|
@Fro-Z oh, I see, so it was the other way around, old versions of emscripten (used for mono builds) does not support it. |
Faless
changed the title
Faless
approved these changes
Dec 9, 2021
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #55593
(There was an exception thrown on FS.mkdir() because the path ends with a trailing slash)