Fix volumetric fog in combination with spotlights #55714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometror
force-pushed
the
fix-fog-spotlight
branch
from
3ca7e83
to
cdde71c
Compare
clayjohn
reviewed
Dec 8, 2021
clayjohn
reviewed
Dec 8, 2021
There was a problem hiding this comment.
Changes to the shadow lookup look good. They are the same as what I did for omnilights in #53353 and what JFons did for scene shaders in 51335
I left a comment about the cluster_type_size I am unsure what the number should be, but my guess is matching the scene shader definition will be best
Geometror
force-pushed
the
fix-fog-spotlight
branch
from
cdde71c
to
da28ca0
Compare
clayjohn
reviewed
Dec 8, 2021
Geometror
force-pushed
the
fix-fog-spotlight
branch
from
da28ca0
to
1da732a
Compare
clayjohn
approved these changes
Dec 9, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the artifacts which show up when using spotlights in combination with volumetric fog.
Fixes both artifacts described in #55527.
(#41357 might be fixed as well for spotlights, needs testing)