Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fixed texture animation speed when using random lifetime #55717

Merged

Conversation

RPicster
Copy link
Contributor

@RPicster RPicster commented Dec 8, 2021

3.x version of #55271

@RPicster RPicster requested review from a team as code owners December 8, 2021 08:45
@Chaosus Chaosus added this to the 3.5 milestone Dec 8, 2021
@akien-mga
Copy link
Member

What about the tex_* parameters in CPUParticles2D? They seem to be initialized to 0 too in 3.x, that's why I thought it might need a deeper dive in the history (and testing) to make sure that everything is working as expected.

@RPicster
Copy link
Contributor Author

RPicster commented Dec 8, 2021

What about the tex_* parameters in CPUParticles2D? They seem to be initialized to 0 too in 3.x, that's why I thought it might need a deeper dive in the history (and testing) to make sure that everything is working as expected.

Oh right! I will take another look, make everything have one style and test it!

@RPicster RPicster force-pushed the 3.x-particles-texture-animation-speed branch from 8741da5 to 28a6d32 Compare December 9, 2021 18:59
@RPicster
Copy link
Contributor Author

RPicster commented Dec 9, 2021

I checked the behaviour of all particle types and the change I did in 4.0 had to be reverted for this PR (changing the tex_* values) because the implementation of the behaviour is different here. Changing those values led to a different default behaviour.

The change was reverted from this PR and now the fix focuses on the animation speed only.

@akien-mga akien-mga merged commit 2780859 into godotengine:3.x Dec 9, 2021
@akien-mga
Copy link
Member

Thanks!

@RPicster RPicster deleted the 3.x-particles-texture-animation-speed branch December 9, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants