Fix rigid body ray cast CCD in 2D and 3D Godot Physics #55773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Dec 10, 2021
akien-mga
approved these changes
Dec 10, 2021
fabriceci
approved these changes
Dec 10, 2021
pouleyKetchoupp
force-pushed
the
fix-raycast-ccd
branch
from
b91fd1a to
6170f73
Compare
akien-mga
reviewed
Dec 10, 2021
For 2D: Raycast CCD now works the same as in 3D, it changes the body's velocity to place it at the impact position instead of generating a contact point that causes a wrong push back. For both 2D and 3D: The raycast CCD process reads and modifies body velocities, so it needs to be moved to pre_solve() instead of setup() to be processed linearly on the main thread, otherwise multithreading can cause some CCD results to be randomly lost when multiple collisions occur.
pouleyKetchoupp
force-pushed
the
fix-raycast-ccd
branch
from
6170f73 to
30a608b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 2D:
Raycast CCD now works the same as in 3D, it changes the body's velocity to place it at the position of impact instead of generating a contact point that causes a wrong push back.
For both 2D and 3D:
The raycast CCD process reads and modifies body velocities, so it needs to be moved to
pre_solve()(processed on the main thread linearly) instead ofsetup()(processed on multiple threads in parallel), otherwise multithreading can cause some CCD results to be randomly lost when multiple collisions occur involving the same body.Fixes the raycast CCD part of #9071
In 2D, shapecast CCD is still not working correctly.