Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add physics material to GridMap #56006

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Add physics material to GridMap #56006

merged 1 commit into from
Jan 6, 2022

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 17, 2021

Closes #3284
image

@KoBeWi KoBeWi added enhancement topic:core topic:physics cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:3d labels Dec 17, 2021
@KoBeWi KoBeWi added this to the 4.0 milestone Dec 17, 2021
@KoBeWi KoBeWi requested a review from a team as a code owner December 17, 2021 00:52
@akien-mga akien-mga requested a review from a team December 17, 2021 08:21
fire
fire reviewed Dec 17, 2021
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this pr have a design for two GridMap cells with two different PhysicMaterials?

@KoBeWi
Copy link
Member Author

KoBeWi commented Dec 17, 2021

No. But it's the same with collision layers.

@JFonS JFonS merged commit 1f0dc02 into godotengine:master Jan 6, 2022
@KoBeWi KoBeWi deleted the 6yearslater branch January 6, 2022 12:59
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire left review comments

@JFonS JFonS JFonS approved these changes

Assignees
No one assigned
Labels
enhancement topic:core topic:physics topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Collision section of GridMap is outdated when compared to TileMap
4 participants
@KoBeWi @akien-mga @fire @JFonS