Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Fix OpenGL flickering. #56059

Merged
merged 1 commit into from
Dec 21, 2021
Merged

[macOS] Fix OpenGL flickering. #56059

merged 1 commit into from
Dec 21, 2021

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 18, 2021

  • Fix incorrect context usage for off-screen drawing.
  • Remove kCGLCEMPEngine, which is causing flicker on macOS 12.1.
  • Disable window redraw during resize, when rendering in the separate thread (window resize is updating GL context from the main thread, which is simultaneously used by the render thread.).

Fixes #56055

@bruvzg
[macOS] Fix OpenGL flickering.
ccdf1a9 
Fix incorrect context usage for off-screen drawing.
Remove kCGLCEMPEngine, which is causing flicker.
Disable window redraw during resize, when rendering in the separate thread.
@bruvzg bruvzg added this to the 3.5 milestone Dec 18, 2021
@bruvzg bruvzg requested a review from a team as a code owner December 18, 2021 19:03
@bruvzg bruvzg mentioned this pull request Dec 18, 2021
Closed
@akien-mga akien-mga merged commit 50e1764 into godotengine:3.x Dec 21, 2021
@akien-mga akien-mga mentioned this pull request Dec 21, 2021
Closed
@bruvzg bruvzg deleted the macos_gl_off_ctx branch December 21, 2021 09:24
@bruvzg bruvzg mentioned this pull request Dec 21, 2021
Merged
@akien-mga
Copy link
Member

Cherry-picked for 3.4.2 via #56122.

@bruvzg bruvzg mentioned this pull request Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:macos regression topic:rendering
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @akien-mga