Fix size issue for ARVR managed viewport #56072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawnjelly
approved these changes
Dec 19, 2021
|
Thanks! |
|
Cherry-picked for 3.4.2. |
|
Thanks @BastiaanOlij ! This was causing me some issues when migrating my VR project to 3.4. 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix applies to 3.x only.
This fixes an issue around an ARVR
Viewportnot rendering if its size is0, 0even though the size is managed by theARVRInterface.It also fixes an issue around Godot getting stuck when attempting to render a
Viewportnot properly initialized because there is noARVRInterfacethat has been initialized (a likely scenario when running the editor)It simply moves the size check to slightly earlier in the rendering process, and set the size to
0, 0if noARVRInterfaceis initialized.fixes #56069