Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TabContainer not setting layout immediately #56206

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 23, 2021

Fixes #23570
The code I removed is done in _repaint().

@KoBeWi KoBeWi added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:gui labels Dec 23, 2021
@KoBeWi KoBeWi added this to the 4.0 milestone Dec 23, 2021
@KoBeWi KoBeWi requested a review from a team as a code owner December 23, 2021 22:47
Copy link
Member

@YeldhamDev YeldhamDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit 8eb1d20 into godotengine:master Jan 5, 2022
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the random_call_deferred_to_the_rescue_once_again branch January 5, 2022 09:58
@OverloadedOrama
Copy link
Contributor

Any chance this bugfix will get cherrypicked for 3.4.3 as well?

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 5, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabContainer doesn't layout its children when first added
4 participants