Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path2D: Check points count before rendering. #56643

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

AnilBK
Copy link
Contributor

@AnilBK AnilBK commented Jan 9, 2022

The Bug:
Add a empty Path2D to the scene. The following error message is shown.

image

Likely an issue from #55516, where Path2D is drawn using draw_polyline whatever the number of points in the curve.

@AnilBK AnilBK requested a review from a team as a code owner January 9, 2022 09:27
@AnilBK AnilBK force-pushed the path2D-check-point-count branch from 612b746 to b770a4d Compare January 9, 2022 09:33
@akien-mga akien-mga requested a review from lawnjelly January 9, 2022 14:15
@akien-mga akien-mga added this to the 4.0 milestone Jan 9, 2022
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 9, 2022
Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch I missed this possibility. 👍

Will need cherry picking to 3.x as well I think.

@akien-mga akien-mga merged commit b6b81e8 into godotengine:master Jan 9, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants