Array
: Relax slice
bound checks to properly handle negative indices
#56668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same is done for
Vector
(and thusPacked*Array
).begin
andend
can now take any value and will be clamped to[-size(), size()]
. Negative values are a shorthand for indexing the arrayfrom the last element upward.
end
is given a defaultINT_MAX
value (which will be clamped tosize()
)so that the
end
parameter can be omitted to go frombegin
to the max sizeof the array.
This makes
slice
works similarly to numpy's and JavaScript's.Fixes #56661.
TODOs:
Packed*Array
sslice