Fix visible background line in intersections in screen-space reflections (3.x) #56843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusting the step grading by one resolves the issue without affecting performance or introducing adverse artifacts.
Calinou
changed the title
clayjohn
approved these changes
Jan 18, 2022
|
Thanks! |
|
Cherry-picked for 3.4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.xversion of #56844.Adjusting the step grading by one resolves the issue without affecting performance or introducing adverse artifacts.
This bug has been around since Godot 3.0, and I finally managed to find a good fix for it 🙂
Preview
Before
After