Make sure MeshLibrary shape array has correct number of elements
#56891
Conversation
rafallus
force-pushed
the
meshlib_shapes_array
branch
from
4336445
to
ed7f842
Compare
| Ref<BoxShape3D> box_shape; | ||
| box_shape.instantiate(); | ||
| arr_shapes[size - 1] = box_shape; |
There was a problem hiding this comment.
I'm not sure about this, that seems pretty arbitrary, and could lead to a lot of instantiations that will then need to be freed and replaced by what the user wants to use.
Wouldn't it be sufficient to just make the step 2 for the SpinBox?
There was a problem hiding this comment.
Wouldn't it be sufficient to just make the step 2 for the SpinBox?
Well not sure that's actually possible currently in the array editor.
There was a problem hiding this comment.
The array is expecting to have a shape. If there is anything else, even an empty Variant() the array won't update and the size won't change. A few lines below that piece of code you can find
if (sd.shape.is_valid()) {
shapes.push_back(sd);
}So, if it isn't a valid shape, nothing happens. Could you think of other way of doing it? It is absolutely arbitrary but is the way I found to do it.
akien-mga
added
bug
cherrypick:3.4
cherrypick:3.x
rafallus
force-pushed
the
meshlib_shapes_array
branch
from
ed7f842
to
5f8b292
Compare
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.4.3. |
The shape array shown in the inspector increases and decreases by 2, ensuring that the last elements (when increasing) is a shape-transform pair.
Fixes: #53897