Fix "Convert to MeshLibrary" not respecting collision transforms #56907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
cherrypick:3.4
cherrypick:3.x
akien-mga
approved these changes
Jan 18, 2022
|
Thanks! |
Logharaa
reviewed
Jan 19, 2022
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing Scene → Convert To... → MeshLibrary... there is an option "Apply MeshInstance Transforms" that prevents the zeroing of the transform of each MeshInstance. Unfortunately this option did not respect the transform of the collision shapes of StaticBody children, so effectively the mesh would be moved away from its "left behind" collision shapes. Now the transforms are respected. Fixes #56172.
Before:
After:
cc @DeleteSystem32