Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix iOS export with manually specified signing/provisioning data. #57203

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 25, 2022

Seems like Xcode now defaults to the Automatic signing mode unless Manual signing style is set in the project.

  • For automatic signing mode only App Store Team ID should be set, the rest can be left blank.
  • For manual signing, Provisioning Profile UUID and Codesign Identity should be also set.

Note: I do not have an Apple Developer account, and can't fully test it, but it seems to be working at least for the ad-hoc mode.

Fixes #57195

@bruvzg bruvzg added this to the 4.0 milestone Jan 25, 2022
@akien-mga akien-mga added cherrypick:3.4 cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jan 25, 2022
@bruvzg bruvzg marked this pull request as ready for review January 25, 2022 19:25
@bruvzg bruvzg requested review from a team as code owners January 25, 2022 19:25
@akien-mga akien-mga merged commit 969780c into godotengine:master Feb 2, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 2, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.4.3.

@bruvzg bruvzg deleted the ios_export_fix branch February 3, 2022 05:59
@franciscod
Copy link

FYI, I still see "iPhone Developer" and "iPhone Distribution" when I'm trying to get the "Automatic" provisioning style. Worked around with this as a wrapper for xcodebuild (changed PATH before invoking Godot)

#!/bin/bash
PBX=out/ios/MyAmazingGame.xcodeproj/project.pbxproj

# undo godot's v3.5.2 wrong take here

sed 's/iPhone Developer//' < $PBX > $PBX.fix
mv $PBX.fix $PBX
sed 's/iPhone Distribution//' < $PBX > $PBX.fix
mv $PBX.fix $PBX

exec /usr/bin/xcodebuild "$@"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS export failing when entering provisioning profile and codesign identity
3 participants