Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTML5] Fetch API now passes credentials. #57934

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Feb 10, 2022

Used default value before, i.e. "same-origin", now uses "include" (i.e. include for cross-origin if cross-origin is allowed).

Fixes #54447

@Faless Faless added bug platform:web topic:porting topic:network cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.4 labels Feb 10, 2022
@Faless Faless added this to the 4.0 milestone Feb 10, 2022
@Faless Faless requested a review from a team as a code owner February 10, 2022 20:20
Used default value before, i.e. "same-origin", now uses "include" (i.e.
include for cross-origin if cross-origin is allowed).
@akien-mga akien-mga merged commit 73f1312 into godotengine:master Feb 10, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 10, 2022
@Faless Faless deleted the js/4.x_fetch_creds branch February 10, 2022 23:53
@akien-mga
Copy link
Member

Cherry-picked for 3.4.3.

@ChronoDK
Copy link

This is causing problems for me. Is there a way to change it back to the default?

@Calinou
Copy link
Member

Calinou commented Feb 28, 2022

This is causing problems for me. Is there a way to change it back to the default?

This will be reverted soon, see #58615.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML5: set Request.credentials value to include sending cookies for cross-origin requests too
4 participants