Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the Profiler Frame Max Functions value to 16384 #58729

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 4, 2022

master version of #43697.

Since the default value is now very high, the settings to adjust it were removed as they're probably not needed anymore.

Since the default value is now very high, the settings to adjust it
were removed as they're probably not needed anymore.
@reduz
Copy link
Member

reduz commented Aug 3, 2022

IMO this is a terrible idea and the default should not have been changed. This is done precisely to protect users from a real stack overflow. If you get one now, Godot will crash and user will never know what happened.

Nevermind, this has another side effect which is that it will consume considerably more bandwidth when profiling, and you risk saturating the connection unnecesarily.

IMO the rule should be, if a value does not need to be changed because nobody asked for it, do not change it. In many cases the limit is set to avoid bottlenecks or performance problems, so I suggest against changing it without asking the right person.

@YuriSizov
Copy link
Contributor

Closing as rejected and due to lack of any follow-up activity.

@YuriSizov YuriSizov closed this Feb 10, 2023
@YuriSizov YuriSizov removed this from the 4.0 milestone Feb 10, 2023
@Calinou Calinou deleted the profiler-frame-max-functions-increase branch February 10, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants