GLES2 Compression on Blend Shapes Fix #58838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compressed vertex positions are used in a blend shapes mesh, we need to make sure we set the w-component of the position vector to 1.0 When octahedral compression is used on normals/tangents, they need to be converted to cartesian floats to be used for blend shapes This conversion also changes the number of components of that vertex attribute, which caused issues because previously there was an assumption that you had the same number of components in the blend shape buffer as you did in the original mesh's buffer (which is not true for oct norm/tang)
The-O-King
commented
Mar 6, 2022
| glVertexAttribPointer(s->attribs[i].index, s->attribs[i].size, GL_FLOAT, GL_FALSE, 8 * 4 * sizeof(float), CAST_INT_TO_UCHAR_PTR(i * 4 * sizeof(float))); | ||
| // When using octahedral compression (2 component normal/tangent) | ||
| // decompression changes the component count to 3/4 | ||
| int size; |
There was a problem hiding this comment.
We could also have a solution which creates a separate Vertex Attributes array for the blend shape vertex buffer so that we don't have to have this check here; but this was the easiest fix, not sure which would be preferable (performance wise adding these checks didn't seem to cause any issues)
akien-mga
approved these changes
Mar 6, 2022
|
Thanks! |
|
Cherry-picked for 3.4.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compressed vertex positions are used in a blend shapes mesh, we
need to make sure we set the w-component of the position vector to 1.0
When octahedral compression is used on normals/tangents, they need to be
converted to cartesian floats to be used for blend shapes
This conversion also changes the number of components of that vertex
attribute, which caused issues because previously there was an
assumption that you had the same number of components in the blend shape
buffer as you did in the original mesh's buffer (which is not true for
oct norm/tang)
Bugsquad edit: Follow-up to #58808.