Fix event coordinate system in Viewport::_sub_windows_forward_input #59118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
force-pushed
the
fix-window-input-event-coordinates
branch
2 times, most recently
from
b92fe26 to
eb4f071
Compare
Sauermann
changed the title
Sauermann
force-pushed
the
fix-window-input-event-coordinates
branch
from
eb4f071 to
091206c
Compare
Sauermann
force-pushed
the
fix-window-input-event-coordinates
branch
from
091206c to
3f7770c
Compare
This was referenced Mar 27, 2022
akien-mga
approved these changes
Mar 28, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
Viewport::_sub_windows_forward_inputdid not take into account, that the parent window-viewport could possibly be stretched. This patch changes this so that event coordinates are converted accordingly.The position of
p_eventis in the coordinate system of the window/viewport.The position of
evis in the coordinate system of the window/viewport with applied thefinal_transform, which is the coordinate system, in which thePopupMenuexpects itsInputEvents.This solves problems like this for stretched Window-Viewports and PopupMenu:
BugPopupMenu.mp4
fix #59573
Part of godotengine/godot-proposals#3866