Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix RichTextLabel CJK text wrap regression #59190

Merged
merged 3 commits into from
Mar 16, 2022
Merged

[3.x] Fix RichTextLabel CJK text wrap regression #59190

merged 3 commits into from
Mar 16, 2022

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Mar 16, 2022 •
edited
Loading

Recent cherry-picks broke RichTextLabel CJK text wrap.

  1. Reverts the cherry-pick commits of Fixed underlines and strikethrough not respecting visible character #37656 and Fixed 0 width issue of rich text label #37840.
  2. Made a new fix for the underline & strikethrough issue these two PRs trying to fix. (RichTextLabel underlining does not respect visible character #21637)

@timothyqiu timothyqiu added this to the 3.5 milestone Mar 16, 2022
@timothyqiu timothyqiu requested a review from a team as a code owner March 16, 2022 10:08
@akien-mga akien-mga merged commit add9049 into godotengine:3.x Mar 16, 2022
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the rtl-visible-lines branch March 16, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:gui
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyqiu @akien-mga