Add GLTF, DAE and FBX importers enforcement for blend shape mask array #59489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyuma
approved these changes
Mar 24, 2022
reduz
approved these changes
Mar 25, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @reduz and @fire in #57945, this PR add blend shape filtering in the importers before adding surface, rather than making blend shape format check less strict. (cc. @lyuma)
Blend shapes are otherwise broken since #57801.
Unfortunately, DAE does not seem to support blend shapes for now. My code just cleans up data set that cannot be. And for FBX, existing import issues prevent me to test thoroughly.